firmware: set the download filename #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boot firmware files published by Qualcomm, even if they are versioned properly, are pusblished as <platform>_bootbinaries.zip. Bitbake expects the version to be there in the downloaded filenames, since all downloads are placed in the same location (DL_DIR). As such installing different versions of the boot binaries will override them each time, and bitbake complains about that (and it causes unnecessary warnings and re-fetch). We can customize the download file name using the 'downloadfilename' attribute in SRC_URI. With this patch, the firmware is downloaded as: downloads/QCM6490_bootbinaries_r1.0_00005.0.zip Signed-off-by: Nicolas Dechesne <[email protected]>
ndechesne
requested review from
quic-vkraleti,
ricardosalveti and
sbanerjee-quic
as code owners
ricardosalveti
approved these changes
Nov 21, 2024
|
2c from my side: when I had to face similar issue for other firmware files, I ended up basically adding |
I don't see any specific reason why we would need to do that. DL_DIR already has pretty much all tarballs for all recipes. Is there anything in particular that would justify that? |
|
In woa case it was easier to keep downloaded files organised. In this case it probably doesn't make such a difference. |
MrCry0
approved these changes
Nov 22, 2024
quic-vkraleti
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boot firmware files published by Qualcomm, even if they are versioned properly, are pusblished as
_bootbinaries.zip. Bitbake expects the version to be there in the downloaded filenames, since all downloads are placed in the same location (DL_DIR). As such installing different versions of the boot binaries will override them each time, and bitbake complains about that (and it causes unnecessary warnings and re-fetch).
We can customize the download file name using the 'downloadfilename' attribute in SRC_URI. With this patch, the firmware is downloaded as:
downloads/QCM6490_bootbinaries_r1.0_00005.0.zip