ci: yocto-patchreview: run blame command to get additional context #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a patch is malformed, the patchreview script can run a git blame command on the patch to provide additional contextual data. The --blame command was failing, and a fix was found, now that this patch is merged in poky: 79ef781499f5 (scripts: patchreview: fix failure when running from a different folder) we can enable --blame in our script. Signed-off-by: Nicolas Dechesne <[email protected]>
ndechesne
requested review from
quaresmajose,
ricardosalveti and
sbanerjee-quic
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a patch is malformed, the patchreview script can run a git blame command on the patch to provide additional contextual data. The --blame command was failing, and a fix was found, now that this patch is merged in poky:
79ef781499f5 (scripts: patchreview: fix failure when running from a different folder)
we can enable --blame in our script.