qcom-ptool: add missing patch signed-off-by #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing patch signed-off-by tag in 0001-ptool.py-Generate-zero-files-in-output-folder-when-s.patch. Signed-off-by: Ricardo Salveti <[email protected]>
ricardosalveti
requested review from
quic-vkraleti,
sbanerjee-quic and
ndechesne
as code owners
lumag
reviewed
Nov 19, 2024
| @@ -8,6 +8,8 @@ The patch allows ptool to generate zerosector files in output directory | |||
| when such directory path is specified as argument to -t option. | |||
|
|
|||
| Upstream-Status: Pending | |||
|
|
|||
There was a problem hiding this comment.
There should be no empty lines between tags IIRC
There was a problem hiding this comment.
I don't think we have this recommendation in OE, even in the docs there is an empty line: https://docs.yoctoproject.org/dev/contributor-guide/recipe-style-guide.html#examples
There was a problem hiding this comment.
I think there are no rule for this in or-core, with grep we can see that all combinations with and without spaces before and after are used. I also usually use a space before the sign-off
ndechesne
approved these changes
Nov 19, 2024
quaresmajose
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing patch signed-off-by tag in
0001-ptool.py-Generate-zero-files-in-output-folder-when-s.patch.