qcom-base: Swap KERNEL_IMAGETYPE and KERNEL_IMAGETYPES #42
Conversation
Update KERNEL_IMAGETYPE to Image.gz and KERNEL_IMAGETYPES to Image. This adjustment provides uncompressed kernel image required for the systemd-boot/UKI. Signed-off-by: Atul Dhudase <[email protected]>
| KERNEL_IMAGETYPE ?= "Image" | ||
| KERNEL_IMAGETYPES ?= "Image.gz" | ||
| KERNEL_IMAGETYPE ?= "Image.gz" | ||
| KERNEL_IMAGETYPES ?= "Image" |
There was a problem hiding this comment.
I believe that these 2 variables are 'merged' together in OE. as such I don't know how this change makes any difference. Can you please point out to the problem you have that led to this patch?
There was a problem hiding this comment.
The issue is that https://github.com/Linaro/meta-qcom/blob/master/recipes-kernel/images/linux-qcom-uki.bb#L117 is not consuming the variable after the merge (which is done in the kernel class), so either we invert as done here or we change meta-qcom to take the variable merge into account.
There was a problem hiding this comment.
thanks for the context. We need to fix meta-qcom instead. something like it's done in meta/classes-recipe/linux-dummy.bbclass. These variables are expected to be used in the kernel recipe, so using them outside of the kernel recipe is 1) not expected, 2) potentially the wrong thing to do.
Perhaps we need to review why linux-qcom-uki.bb was done like that.
In response to qualcomm-linux/meta-qcom-hwe#42. KERNEL_IMAGETYPES is not enough to be checked, since kernel types can also be set using KERNEL_IMAGETYPE or KERNEL_ALT_IMAGETYPE. Like it's done in OE-core kernel class, we need to combine all these variables. Signed-off-by: Nicolas Dechesne <[email protected]>
|
Closing as Linaro/meta-qcom#666 was just merged. |
Update KERNEL_IMAGETYPE to Image.gz and KERNEL_IMAGETYPES to Image. This adjustment provides uncompressed kernel image required for the systemd-boot/UKI.