Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Repolinter checks on main #35

Merged

Conversation

mynameistechno
Copy link
Contributor

Adds Repolinter checks to PRs and pushes to main. Repoliner is a TODO Group (Linux Foundation) created project that lints for common open source repo issues.

The config is pulled from our main QuIC org, but if we need to override we can extend and configure it locally.

Let me know if any concerns with enabling this check on this repo. Also, should we enable for other repos such as qcom distro?

Adds the Repolinter check on push and PRs to main.

Signed-off-by: Mark Matyas <[email protected]>
@mynameistechno
Copy link
Contributor Author

Looking at this ...

image

@mynameistechno
Copy link
Contributor Author

Looking at this ...

image

Ok, I had to add that action to the allowed list

@ricardosalveti ricardosalveti added this to the 10/24 milestone Oct 9, 2024
@@ -1,4 +1,6 @@
#!/bin/sh -e
# Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
# SPDX-License-Identifier: MIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can exclude such trivial shell scripts, but it's probably easier to add the markings.

Copy link
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 9023e9f into qualcomm-linux:main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants