Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Archive images on shared disk #19

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

doanac
Copy link
Contributor

@doanac doanac commented Sep 13, 2024

Save files on NFS share between runs for use by other workflows

@doanac
Copy link
Contributor Author

doanac commented Sep 13, 2024

Not really for merge just yet. I'm toying with an idea on how to get data we build available to lava. This is just one piece of that process.

@doanac doanac force-pushed the archive-build branch 4 times, most recently from 3480c06 to 5701511 Compare September 13, 2024 19:51
@EmbeddedAndroid EmbeddedAndroid added the qa Quality Assurance label Sep 13, 2024
@EmbeddedAndroid EmbeddedAndroid added this to the picanha milestone Sep 13, 2024
@doanac
Copy link
Contributor Author

doanac commented Sep 13, 2024

@mwasilew - With a change like this, I can set up a file service for you to make authenticated downloads.
The URL format is: /GITHUB_RUN_ID/PLATFORM/ARTIFACT. eg:

curl -v -H "Authentication: token <SUPER SECRET VALUE>" \
 https://quic-yocto-fileserver-1029608027416.us-central1.run.app/10855251928/qcm6490-idp/core-image-minimal-qcm6490-idp.rootfs.ext4

@mwasilew
Copy link
Contributor

Is the host name going to remain https://quic-yocto-fileserver-1029608027416.us-central1.run.app or there will be some more convenient CNAME?

@doanac
Copy link
Contributor Author

doanac commented Sep 16, 2024

Is the host name going to remain https://quic-yocto-fileserver-1029608027416.us-central1.run.app or there will be some more convenient CNAME?

It will be the long name. Otherwise we'll have to set up DNS, a mechanism to keep certs fresh, etc.

@mwasilew
Copy link
Contributor

That's OK. Just wanted to confirm.

@doanac doanac mentioned this pull request Sep 16, 2024
@EmbeddedAndroid EmbeddedAndroid linked an issue Sep 17, 2024 that may be closed by this pull request
@@ -28,3 +28,10 @@ jobs:
mkdir build
cd build
kas build ../ci/${{ matrix.machine }}.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using

publish:
needs: kas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. once we have a bootable image, I'll update this PR

Save files on NFS share between runs for use by other workflows

Signed-off-by: Andy Doan <[email protected]>
@doanac
Copy link
Contributor Author

doanac commented Oct 30, 2024

@ricardosalveti @mwasilew - this PR is finally ready for review and to be merged.

Copy link
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwasilew
Copy link
Contributor

Copy link
Contributor

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we should unify the /srv/gh-runners/quic-yocto/builds using global environment variables but this can be done later

@doanac doanac merged commit 80f4c71 into qualcomm-linux:main Oct 31, 2024
7 checks passed
@doanac doanac deleted the archive-build branch October 31, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Quality Assurance
Projects
Development

Successfully merging this pull request may close these issues.

Build packaging
6 participants