-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Archive images on shared disk #19
Conversation
Not really for merge just yet. I'm toying with an idea on how to get data we build available to lava. This is just one piece of that process. |
3480c06
to
5701511
Compare
@mwasilew - With a change like this, I can set up a file service for you to make authenticated downloads.
|
Is the host name going to remain https://quic-yocto-fileserver-1029608027416.us-central1.run.app or there will be some more convenient CNAME? |
It will be the long name. Otherwise we'll have to set up DNS, a mechanism to keep certs fresh, etc. |
That's OK. Just wanted to confirm. |
.github/workflows/pull-request.yml
Outdated
@@ -28,3 +28,10 @@ jobs: | |||
mkdir build | |||
cd build | |||
kas build ../ci/${{ matrix.machine }}.yml | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using
publish:
needs: kas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. once we have a bootable image, I'll update this PR
0a05668
to
5496648
Compare
Save files on NFS share between runs for use by other workflows Signed-off-by: Andy Doan <[email protected]>
@ricardosalveti @mwasilew - this PR is finally ready for review and to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@doanac downloads work: https://lava.infra.foundries.io/scheduler/job/55277#L261 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we should unify the /srv/gh-runners/quic-yocto/builds
using global environment variables but this can be done later
Save files on NFS share between runs for use by other workflows