Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add yocto-check-layer helper script #14

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

quaresmajose
Copy link
Contributor

Add the yocto-check-layer with a script to be easy to replicate locally.

Also change:

  • add --no-auto
    It is required if kas runs inside the bsp layer. So to make the yocto-check-layer
    happy whether it runs inside or outside it is better to have this arg.

  • use the base.yml
    The --machines can be used when we need to check the layer with one or more machines.
    By default the machine is not required because the yocto-check-layer-wrapper run's
    on a clean build dir.

Add the yocto-check-layer with a script to be easy to replicate locally.

Also change:

- add --no-auto
  It is required if kas runs inside the bsp layer. So to make the yocto-check-layer
  happy whether it runs inside or outside it is better to have this arg.

- use the base.yml
  The --machines can be used when we need to check the layer with one or more machines.
  By default the machine is not required because the yocto-check-layer-wrapper run's
  on a clean build dir.

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose quaresmajose requested a review from a team September 12, 2024 14:29
@ricardosalveti
Copy link
Contributor

Please extend the commit message from 'ci: call the yocto-check-layer helper script' explaining the reason for the change.

Call the yocto-check-layer helper as it will be easy to replicate
locally the same that run on the ci job.

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose
Copy link
Contributor Author

Please extend the commit message from 'ci: call the yocto-check-layer helper script' explaining the reason for the change.

done

Copy link
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit fcdd463 into qualcomm-linux:main Sep 12, 2024
4 of 5 checks passed
@EmbeddedAndroid EmbeddedAndroid added this to the picanha milestone Sep 12, 2024
@EmbeddedAndroid EmbeddedAndroid added the qa Quality Assurance label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Quality Assurance
Projects
Development

Successfully merging this pull request may close these issues.

3 participants