ci: Update upload logic to use new streaming support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doanac
requested review from
quic-vkraleti,
ricardosalveti,
sbanerjee-quic and
ndechesne
as code owners
MrCry0
reviewed
Dec 12, 2024
.github/workflows/build-yocto.yml
Outdated
| if [[ $line == STATUS=* ]]; then | ||
| if [[ $line == "STATUS=OK" ]]; then | ||
| break | ||
| else |
There was a problem hiding this comment.
The indents seem broken. Is it a github UI bug or a real bug in code?
doanac
force-pushed
the
stream-uploads
branch
from
f707b26 to
9de3618
Compare
MrCry0
approved these changes
Dec 12, 2024
The file server now has a way to stream progress if the client side has logic. This should help with 2 things: * better live debug * less 503 errors that happen due to the server taking too long to deliver its status code Signed-off-by: Andy Doan <[email protected]>
doanac
force-pushed
the
stream-uploads
branch
from
9de3618 to
24c0ed6
Compare
EmbeddedAndroid
approved these changes
Dec 13, 2024
| fi | ||
| fi | ||
| done | ||
| [ $okay -eq 1 ] && break |
There was a problem hiding this comment.
@doanac I believe that this may not work as expected if the bash script code run with set -e.
In this case when the okay != 1 the script will abort as the evaluations of the expression will return false, what causes abort when set -e is active.
We need to replace that with if conditional statement
if [ $okay -eq 1 ]; then
break
fi
There was a problem hiding this comment.
I didn't test anything to verify what I said but if what I said is true, the consequence is that there are no retries and the loop aborts on the first failure when okay != 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file server now has a way to stream progress if the client side has logic. This should help with 2 things: