Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix style issues/add flash instructions #108

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

igoropaniuk
Copy link
Contributor

@igoropaniuk igoropaniuk commented Dec 11, 2024

  1. Address markdown style issues reported by the linter
  2. Add initial flash instructions for Qualcomm® RB3 Gen 2 Development Kit.

@igoropaniuk igoropaniuk force-pushed the flash_instructions branch 2 times, most recently from 1f43108 to 4618dec Compare December 11, 2024 14:05
@igoropaniuk igoropaniuk changed the title README: add flash instructions README: fix style issues/add flash instructions Dec 11, 2024
@igoropaniuk igoropaniuk requested a review from mwasilew December 11, 2024 14:36
Copy link

@mbolivar mbolivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@igoropaniuk igoropaniuk added the documentation Improvements or additions to documentation label Dec 11, 2024

Make sure that ModemManager is not running, disable it if necessary.
Location of all DIP switches, USB debug port and buttons (`F_DL` for instance)
can be found on [RB3 Gen 2 Quick Start Guide](https://docs.qualcomm.com/bundle/publicresource/topics/80-70014-253/ubuntu_host.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the generic instructions here is fine, but this layer is expected to support multiple machines (there is already support for ride), so should we isolate the board specific instructions and just have a link instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RIDE one needs to use alpaca to set the EDL mode. I don't think there are public instructions available for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardosalveti makes sense, will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to make flash instructions as much board-agnostic as possible. I've moved board specific details to a dedicated section.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@igoropaniuk
Copy link
Contributor Author

@ricardosalveti @mwasilew @ndechesne any additional comments/suggestions?

@ndechesne
Copy link
Contributor

I am not sure I like duplicating the documentation here... but for now we should go ahead and merge. we can always reorganize things later once we have a better idea about how the whole thing will work out.

Fix markdown style issues using markdownlint tool [1]:

$ cat README.md | mdl
(stdin):70: MD004 Unordered list style
(stdin):71: MD004 Unordered list style
(stdin):72: MD004 Unordered list style
(stdin):73: MD004 Unordered list style
(stdin):74: MD004 Unordered list style
(stdin):39: MD010 Hard tabs
(stdin):40: MD010 Hard tabs
(stdin):41: MD010 Hard tabs
(stdin):43: MD010 Hard tabs
(stdin):44: MD010 Hard tabs
(stdin):45: MD010 Hard tabs
(stdin):47: MD010 Hard tabs
(stdin):48: MD010 Hard tabs
(stdin):49: MD010 Hard tabs
(stdin):3: MD013 Line length
(stdin):9: MD013 Line length
(stdin):26: MD013 Line length
(stdin):34: MD013 Line length
(stdin):36: MD013 Line length
(stdin):54: MD013 Line length
(stdin):61: MD013 Line length
(stdin):78: MD013 Line length
(stdin):33: MD022 Headers should be surrounded by blank lines
(stdin):42: MD029 Ordered list item prefix
(stdin):46: MD029 Ordered list item prefix
(stdin):39: MD031 Fenced code blocks should be surrounded by blank lines
(stdin):41: MD031 Fenced code blocks should be surrounded by blank lines
(stdin):43: MD031 Fenced code blocks should be surrounded by blank lines
(stdin):45: MD031 Fenced code blocks should be surrounded by blank lines
(stdin):47: MD031 Fenced code blocks should be surrounded by blank lines
(stdin):49: MD031 Fenced code blocks should be surrounded by blank lines
(stdin):57: MD034 Bare URL used

[1] https://github.com/markdownlint/markdownlint
Signed-off-by: Igor Opaniuk <[email protected]>
Add initial flash instructions for Qualcomm® RB3 Gen 2 Development Kit.

Signed-off-by: Igor Opaniuk <[email protected]>
@igoropaniuk
Copy link
Contributor Author

Rebased onto the latest main

Copy link
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti
Copy link
Contributor

In order to merge we need a +1 from @mwasilew, as he requested changes.

@mwasilew
Copy link
Contributor

Sorry, I missed the fixes from @igoropaniuk.

@ricardosalveti ricardosalveti merged commit 9fd1724 into qualcomm-linux:main Dec 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

5 participants