Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer.conf: increase BBFILE_PRIORITY to 6 #100

Merged

Conversation

koenkooi
Copy link
Contributor

@koenkooi koenkooi commented Dec 4, 2024

This gets us slightly more deterministic behaviour since most layers, inclusing OE-core, set it to 5. When priorities are equal, the ordering in BBLAYERS is used to resolve conflicts. Since this layer was at '5', getting the ordering wrong would negate .bbappends and shadowed recipes.

Upstream bitbake wants to phase this out, but for the time being, let's decrease the opportunities for users to get this wrong.

Fixes: #98

This gets us slightly more deterministic behaviour since most layers,
inclusing OE-core, set it to 5. When priorities are equal, the ordering
in BBLAYERS is used to resolve conflicts. Since this layer was at '5',
getting the ordering wrong would negate .bbappends and shadowed recipes.

Upstream bitbake wants to phase this out, but for the time being, let's
decrease the opportunities for users to get this wrong.

Fixes: qualcomm-linux#98

Signed-off-by: Koen Kooi <[email protected]>
Copy link
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 18ce0b2 into qualcomm-linux:main Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Evaluate increasing BBFILE_PRIORITY to get more deterministic behaviour
3 participants