Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging in note text Script breaks the Table preview #101

Open
ghost opened this issue Jun 29, 2020 · 8 comments
Open

Tagging in note text Script breaks the Table preview #101

ghost opened this issue Jun 29, 2020 · 8 comments

Comments

@ghost
Copy link

ghost commented Jun 29, 2020

I use the @tag tagging note text with #tag. When you use it like this it breaks the table preview.
When you use @tag it works. I know i know # is not optimal for tagging but in 1writer they use for tagging the notes so thats my problem.

Edit: its enough when you set the # in the Tag word maker setting

@pbek
Copy link
Member

pbek commented Jun 29, 2020

Can you please mention the authors of the script (like advised in the issue template). You will find the authors in the Script repository.

@ghost
Copy link
Author

ghost commented Jun 29, 2020

Can you please mention the authors of the script (like advised in the issue template). You will find the authors in the Script repository.

Sorry mention here?

Can you please mention the authors of the script (like advised in the issue template). You will find the authors in the Script repository.

@Maboroshy can you take a look?

@Maboroshy
Copy link
Member

Could you provide an example.

I've set # as a tag word marker and put the following text into the note:

| 1 | 2 | 3 |
|---|---|---|
| #tag | 2 | 3 |

I got editor syntax highlighting, rendered note preview and the tag all working with QOwnNotes 20.4.12 on my Linux system.

@ghost
Copy link
Author

ghost commented Jun 29, 2020

Could you provide an example.

I've set # as a tag word marker and put the following text into the note:

| 1 | 2 | 3 |
|---|---|---|
| #tag | 2 | 3 |

I got editor syntax highlighting, rendered note preview and the tag all working with QOwnNotes 20.4.12 on my Linux system.

Not yet but tomorrow i can do. I work on Win10 with Qownnotes version 20.6.11

@ghost
Copy link
Author

ghost commented Jun 30, 2020

It is enough to set a hashtag in the tag word marker and the table preview will not work anymore. As soon as you use for example an @ the preview will work again.
Image 1
Image 2

@Maboroshy
Copy link
Member

I've updated QON and I can reproduce your issue. Maybe it's some kind of minor deprecation.
The only part of the script that affects html is the tag highlighting feature of the script. I've made the highlighting color setting empty at that resolved the issue.
Try if it works for you.

@ghost
Copy link
Author

ghost commented Jul 1, 2020

I've updated QON and I can reproduce your issue. Maybe it's some kind of minor deprecation.
The only part of the script that affects html is the tag highlighting feature of the script. I've made the highlighting color setting empty at that resolved the issue.
Try if it works for you.

Yes it works when i empty the color setting. The preview shows the table correct

@Maboroshy
Copy link
Member

I've updated the script. Please, test if it fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants