in-note-text-tagging: HTML tag visible in preview when # used as tag word marker #131
Comments
marcusyoung
changed the title
|
Something like #76? |
|
I'll look into this. |
|
I've updated the script. Please, test if it fixes the issue. |
|
The issue with the stray tag has been fixed. However, it has now caused very odd behaviour. It seems that all single quotation marks and forward slashes in code blocks are replaced by ASCII code in the selected preview tag colour (e.g. the default purple) preceded by an & sign. Here is an example. What code should look like: What it now looks like in preview: |
|
Weird. I can't reproduce your case. I've typed in your text but it renders correctly. The issue was that I've used post-render hook to put in tag highlighting into hmtl, but it messed with other html tags made by rendering. That caused the issue. For the fix I switched to pre-render hook, so the script puts html tags into markdown text. This hook wasn't available when I've first implemented the highlighting. The pre-render hook should not affect markdown rendering in any way. So that's weird. Could you post your script setting, a line of markdown that is affected by this and the html the app makes of it (you can right click on the preview pane and export it). For now it looks like I'd better drop tags highlighting. Maybe make it off by default and put some warnings to the description. Looks like there's no easy way to make it safe. Only parsing whole html DOM will root out all corner cases. |
|
Requested information below. Script settings:
MarkdownHTML |
|
I have not found a fix for this. As of now the script should not mess with html, only prerendered markdown. So it's some kind of clash between what the script does and what renderer does. Even worse, the html injection I've used for highlighting messes tags in the code blocks. And that cannot be fixed at all. I've removed tag highlighting feature from the script. The new version is in the repo. |
@Maboroshy
This issue occurs when selecting # as the tag word marker.
Expected behaviour
No tag to be visible in the note preview pane.
Actual behaviour
Part of an HTML tag is visible in the preview pane:
class="preview">Seems to be related to #101 as the issue is also resolved when the colour setting for tag highlighting is left blank.
The text was updated successfully, but these errors were encountered: