SLF4J-165 Handling of unknown (custom) priorities is different than i… #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n log4j (throwing an IllegalStateException than using the effective level of the given Priority / Level / Category) Signed-off-by: DavesMan <[email protected]>
DavesMan
force-pushed
the
1.7-maintenance
branch
from
2aec4d8
to
8ba8e14
Compare
DavesMan
commented
Jan 28, 2022
| @@ -323,7 +323,8 @@ private int priorityToLevelInt(Priority p) { | |||
| case Priority.FATAL_INT: | |||
| return LocationAwareLogger.ERROR_INT; | |||
| default: | |||
| throw new IllegalStateException("Unknown Priority " + p); | |||
| slf4jLogger.warn("Unknown Priority " + p); | |||
| return LocationAwareLogger.TRACE_INT; | |||
There was a problem hiding this comment.
Original JIRA suggests DEBUG level. TRACE will be visible everywhere. So feel free to change the corrected logging level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n log4j (throwing an IllegalStateException than using the effective level of the given Priority / Level / Category)