Now you can submit pressing shift+enter #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caballerog
reviewed
Nov 5, 2017
| if (event.charCode === 13 && event.shiftKey) { | ||
| this.save(); | ||
| this.onEscape(event); | ||
| } |
There was a problem hiding this comment.
if and else do the same action (this.save() and this.onEscape(event)) then is not necessary if-else. You would rethink the condition using an OR operator maybe.
If you have problems with this logic, contact me and can rethink together.
Caballerog
requested changes
Nov 5, 2017
…arent from method
Caballerog
requested changes
Nov 5, 2017
| super.onKeyPress(event); | ||
| if ((this.config.saveOnEnter && event.charCode === 13 && !event.shiftKey) || | ||
| (!this.config.saveOnEnter && event.charCode === 13 && event.shiftKey)) { | ||
| this.save(); |
There was a problem hiding this comment.
(A && B && !C) || (!A && B && C)
What's the common factor? ;-)
Caballerog
approved these changes
Nov 5, 2017
alisalama
approved these changes
May 24, 2018
|
@xxxTonixxx, any chance of merging the pull request? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93