refactor: use external color handling #1611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxxmaxx
commented
Sep 18, 2024
| @@ -200,65 +194,64 @@ describe('styling', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| const hasEnoughContrast = (a, b) => getContrast(a, b) > CONTRAST_THRESHOLD; | |||
| // const hasEnoughContrast = (a, b) => getContrast(a, b) > CONTRAST_THRESHOLD; | |||
There was a problem hiding this comment.
TODO: potentially move some of these tests to chart-modules
haxxmaxx
commented
Sep 18, 2024
| @@ -116,14 +110,14 @@ describe('styling', () => { | |||
| expect(styles.search.color).toEqual('object.listBox,content,color'); | |||
| }); | |||
| it('search - should get desired color if contrasting enough', () => { | |||
| themeApi.getStyle = () => '#999'; | |||
| themeApi.getStyle = () => '#888888'; | |||
There was a problem hiding this comment.
the contrast for this was actually pretty bad (< 3:1) which isn't acceptable in any case. Probably due to the incorrect contrast calculations, and the arbitrary threshold, this was considered good enough
|
Putting this back to draft since it requires quite a lot of testing to mitigate the risk. Starting with this PR #1625 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Color class has been modernized and moved to qlik-chart-modules. This means we can remove Color class and some other color stuff that was implemented twice.
Adding qlik-chart-modules to the deps does increase the bundle size. It is noticeable but too acceptable...
Requirements checklist
yarn specWhen build and tests have passed: