Add quimb_gate
, which returns a single quimb gate
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
quimb_gate
function that is meant to return a single gate. Right now it handles xxplusyygate as a special case in the old_gen_quimb_gates
function because it maps to multiple quimb gates, but we can factor this out upon the next quimb release, as xxplusyygate will then be available in quimb (as a givens2 rotation, IIRC).I think the main design decision here it to decide whether
Barrier
should map toNone
or an identity ("IDEN"
).I tried adding some tests, but it was difficult to add meaningful tests when even the following fails
Fixes #3.