Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Drop python 3.8 support #639

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

(WIP) Drop python 3.8 support #639

wants to merge 6 commits into from

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Oct 17, 2024 •
edited
Loading

Summary

Addresses #638

Details and comments

@t-imamichi t-imamichi changed the title Bump minimum supported python version to 3.9 (WIP) Bump minimum supported python version to 3.9 Oct 17, 2024
@t-imamichi t-imamichi changed the title (WIP) Bump minimum supported python version to 3.9 (WIP) Drop python 3.8 support Oct 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11511328161

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.857%
Totals Coverage Status
Change from base Build 11511325326: 0.0%
Covered Lines: 4446
Relevant Lines: 4788
💛 - Coveralls

@TolisChal
Copy link
Collaborator

Thanks @t-imamichi! This PR looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TolisChal TolisChal TolisChal approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner will be requested when the pull request is marked ready for review stefan-woerner is a code owner

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm woodsp-ibm will be requested when the pull request is marked ready for review woodsp-ibm is a code owner

@thkleinert thkleinert Awaiting requested review from thkleinert thkleinert will be requested when the pull request is marked ready for review thkleinert is a code owner

@Dniskk Dniskk Awaiting requested review from Dniskk Dniskk will be requested when the pull request is marked ready for review Dniskk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-imamichi @coveralls @TolisChal