Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to access and iterate over function attributes. #259

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Adding ability to access and iterate over function attributes. #259

merged 7 commits into from
Oct 20, 2023

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Oct 19, 2023

Fixes #252

@idavis idavis requested a review from cesarzc October 19, 2023 21:17
@idavis idavis self-assigned this Oct 19, 2023
@idavis idavis marked this pull request as ready for review October 20, 2023 17:54
swernli
swernli approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, happy with whatever Python constant naming pattern you decide to land on.

@idavis idavis merged commit 26885c9 into main Oct 20, 2023
11 checks passed
@idavis idavis deleted the iadavis/attr-iteration branch October 20, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarzc cesarzc cesarzc approved these changes

@swernli swernli swernli approved these changes

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

Assignees

@idavis idavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to iterate over all elements in AttributeSet
3 participants
@idavis @cesarzc @swernli