Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Initialization, Finalization, and EntryPoint Handling Workstream Definition #18

Merged
merged 9 commits into from
May 25, 2022

Conversation

amccaskey
Copy link

We propose a new workstream focused on updating the specification to handle QIR runtime library initialization, finalization, and entrypoint handling with input parameterization. Opening this PR as a first step to getting this workstream approved and inviting the QIR Alliance members and the community to provide feedback and input on this workstream definition.

@amccaskey amccaskey added enhancement New feature or request workstream Official workstream of the QIR Alliance under review Pending approval by the QIR Alliance steering committee labels Feb 23, 2022
@amccaskey amccaskey self-assigned this Feb 23, 2022
…on link to point at fork for now.

Signed-off-by: Alex McCaskey <[email protected]>
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
Copy link
Author

@bettinaheim @DmitryLyakh @rtvuser1 @ffrachon @kalzoo @qci-petrenko @dan1pal

I have updated the workstream proposal with feedback from the discussion at today's steering committee meeting. Please take a look and review. With your approval we will consider this workstream proposal accepted and I will begin working to publicize and set up the first workstream working meeting. If you see anything lacking let's discuss here and iterate on the document.

The proposal has been updated to highlight the need for the workstream to define what is a valid return type for an EntryPoint. It has been updated to highlight the utility of QIR code without main or EntryPoint (as archived library code for modular reuse). The future work section has been updated to note that the return of quantum results and further discussion on modular QIR is to be left for future workstreams.

Copy link

@dan1pal dan1pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a fun project. It is clear and well-scoped.

Copy link
Collaborator

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible clarifying comment, but it’s non-blocking. Thanks for the good work here @amccaskey

workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@rtvuser1 rtvuser1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very well-defined.
Schedule dates are missing, but I assume that this will come later as work is underway

Copy link
Member

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from minor comments

profile/README.md Outdated Show resolved Hide resolved
workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md Outdated Show resolved Hide resolved
workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md Outdated Show resolved Hide resolved
@bettinaheim bettinaheim merged commit 5b39ef7 into qir-alliance:main May 25, 2022
@bettinaheim bettinaheim added approved Approved in principle by the QIR Alliance steering committee and removed under review Pending approval by the QIR Alliance steering committee labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved in principle by the QIR Alliance steering committee enhancement New feature or request workstream Official workstream of the QIR Alliance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants