-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime Initialization, Finalization, and EntryPoint Handling Workstream Definition #18
Conversation
Signed-off-by: Alex McCaskey <[email protected]>
…meeting. Signed-off-by: Alex McCaskey <[email protected]>
Signed-off-by: Alex McCaskey <[email protected]>
…on link to point at fork for now. Signed-off-by: Alex McCaskey <[email protected]>
Signed-off-by: Alex McCaskey <[email protected]>
…22 SC meeting. Signed-off-by: Alex McCaskey <[email protected]>
Signed-off-by: Alex McCaskey <[email protected]>
@bettinaheim @DmitryLyakh @rtvuser1 @ffrachon @kalzoo @qci-petrenko @dan1pal I have updated the workstream proposal with feedback from the discussion at today's steering committee meeting. Please take a look and review. With your approval we will consider this workstream proposal accepted and I will begin working to publicize and set up the first workstream working meeting. If you see anything lacking let's discuss here and iterate on the document. The proposal has been updated to highlight the need for the workstream to define what is a valid return type for an EntryPoint. It has been updated to highlight the utility of QIR code without main or EntryPoint (as archived library code for modular reuse). The future work section has been updated to note that the return of quantum results and further discussion on modular QIR is to be left for future workstreams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a fun project. It is clear and well-scoped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible clarifying comment, but it’s non-blocking. Thanks for the good work here @amccaskey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very well-defined.
Schedule dates are missing, but I assume that this will come later as work is underway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm aside from minor comments
Signed-off-by: Alex McCaskey <[email protected]>
We propose a new workstream focused on updating the specification to handle QIR runtime library initialization, finalization, and entrypoint handling with input parameterization. Opening this PR as a first step to getting this workstream approved and inviting the QIR Alliance members and the community to provide feedback and input on this workstream definition.