Add feature map tool: Make highlight width always bigger than rubberband #59447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure if I should change this as well: the color of the highlight is currently set from the Identify tool's settings. This has been the case for point features for probably quite some time so I felt reticent to change it in case someone's using it. But IMO it'd make more sense to use the rubberband's colors. |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
approved these changes
Nov 25, 2024
JuhoErvasti
deleted the
50671_feature_attributes_form_should_have_a_way_to_highlight_feature_on_map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no issue for this, since this addresses an oversight in #59424. I wasn't sure if one should be created in this case.
The highlight width was hardcoded to 2, which didn't take into account the user having potentially changed the rubberband width. Now the width will always be set as wider than the rubberband.
I also applied the width to polygons for consistency and in case the user has set an opaque rubberband.