Refactor QgsTextRenderer internal methods, optimise buffer render #59414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework internals of QgsTextRenderer horizontal text rendering, so that: 1. It's easier to read, cleaning up years of accumulated cruft 2. Split out bits into smaller functions 3. Reduce the amount of duplicate code for text layout, so that there's only one function responsible for horizontal text layout instead of multiple 4. Add shortcut optimisations for rendering text + buffer/shadow at the same time, instead of always drawing these completely independantly of each other and incurring the cost of text path calculation multiple times for the same bit of text. In a simple benchtest this reduces the time required for rendering many text fragments with buffers from 40 seconds to 27 seconds. There's still more we could do here, but it's a start...
nyalldawson
added
Optimization
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nirvn
approved these changes
Nov 18, 2024
Co-authored-by: Mathieu Pellerin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework internals of QgsTextRenderer horizontal text rendering, so that:
This also fixes situations where text shadow could be slightly cropped, with a couple of pixels (or more) missing from the edges.
All test mask + reference image updates are correct, and have been checked careful to ensure no regressions (just slightly different subpixel text placement, or improvements over the previous reference images)
There's still more we could do here, but it's a start...