-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastChat api model #198
FastChat api model #198
Conversation
…s implementation ENGINE_NAME=jais-13b-chat selectes the model among the loaded ones and AZURE_API_URL='http://10.4.64.46:5004/v10' defines the API base. It can be tested with curl http://10.4.64.46:5004/v1/models
Apologies for not getting to this sooner, but I was in the middle of some refactoring that might make things easier here; Since its really just using the OpenAI (previously GPTChatCompletionModel in our case), shall we just inherit from it? Something like: class FastChatModel(OpenAIModel):
def __init__(api_base, api_key, model_name, **kwargs):
api_base = api_base or os.getenv("FASTCHAT_API_URL")
... # something similar for api_key and model_name
# checks for valid config settings)
super(FastChatModel, self).__init__(api_base=api_base, api_key=api_key, model_name=model_name, **kwargs) should do the trick without much re-implementation, what do you think? We can also do it just for ChatCompletion and not the old legacy string-based way. Let me know, we can discuss in person if you like! |
This sounds good! Thanks! I will update the model based on the new refactoring. I'll get back to you if needed. |
environment variables: |
No description provided.