Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize assets and unify naming scheme #191

Merged
merged 26 commits into from
Sep 6, 2023
Merged

Conversation

fdalvi
Copy link
Collaborator

@fdalvi fdalvi commented Aug 31, 2023

A new naming scheme roughly corresponding to
language_code/task_category/task/asset.py
is introduced in this commit. Model names have also been standardized, along with removal of some duplicate assets.

A new naming scheme roughly corresponding to
	language_code/task_category/task/asset.py
is introduced in this commit. Model names have also been standardized,
along with removal of some duplicate assets.
@fdalvi fdalvi self-assigned this Aug 31, 2023
@fdalvi
Copy link
Collaborator Author

fdalvi commented Aug 31, 2023

@firojalam @MaramHasanain if you guys can take a quick look (easiest way is to look under Files, and see the sidebar) if everything looks okay; there are a couple duplicates that I will fix shortly, but please take a look at the overall structure to make sure I didn't miss something.

Edit: All duplicate/missing assets are now fixed

@fdalvi
Copy link
Collaborator Author

fdalvi commented Aug 31, 2023

Also, I think we should talk about this general directory structure in our CONTRIBUTING.md file

@fdalvi fdalvi force-pushed the maintenance/reorganize_assets branch from 25ebf9b to f51a7b2 Compare August 31, 2023 12:05
Copy link
Contributor

@MaramHasanain MaramHasanain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments and suggestions for individual files

@fdalvi fdalvi force-pushed the maintenance/reorganize_assets branch from 5f2b417 to 76627b9 Compare September 5, 2023 06:18
Copy link
Collaborator Author

@fdalvi fdalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we are not worrying about Khouja/UnifiedFC for now yea?

@fdalvi fdalvi force-pushed the maintenance/reorganize_assets branch from 04f7492 to d699309 Compare September 5, 2023 07:42
@fdalvi fdalvi merged commit 6509529 into main Sep 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants