Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/init code #1

Merged
merged 83 commits into from
Apr 10, 2024
Merged

Feature/init code #1

merged 83 commits into from
Apr 10, 2024

Conversation

QBY-EstebanValverde
Copy link
Collaborator

@QBY-EstebanValverde QBY-EstebanValverde commented Sep 11, 2023

Description

Initial code of module.

Change overview (tick true):

  • This introduces backward incompatible changes
  • This adds a new backward compatible Feature
  • This fixes a Bug

Version information:

  • Previous Version: None

How Has This Been Tested?

  • Plan of all examples was successful
  • Apply of basic and advance example was successful.
    (write_accelerator example is blocked due to missing CPU quotas in test subscriptions)

Checklist:

  • I have run tests and documented them above
  • I have performed a self-review of my own code
  • I have updated the documentation
  • I have updated the CHANGELOG

Copy link
Member

@QBY-MarkusMaring QBY-MarkusMaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure each of the examples is runable without any further modification as a test. I got an error regarding var.virtual_machine_config.availability_set_id when running the basic example

README.md Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
locals.tf Show resolved Hide resolved
extension_azuremonitor.tf Outdated Show resolved Hide resolved
extension_azuremonitor.tf Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
data_disk.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@QBY-MarkusMaring QBY-MarkusMaring self-requested a review April 9, 2024 09:56
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the module doesn't like it's variables to be null

variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
@QBY-MarkusMaring QBY-MarkusMaring requested a review from a user April 9, 2024 11:37
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
ghost
ghost previously approved these changes Apr 10, 2024
variables.tf Outdated Show resolved Hide resolved
@QBY-MarkusMaring QBY-MarkusMaring merged commit 9b949d9 into main Apr 10, 2024
1 check passed
@QBY-MarkusMaring QBY-MarkusMaring deleted the feature/init_code branch April 10, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants