Feat: Add discord to players DB table #1135
Conversation
| @@ -437,10 +438,11 @@ function QBCore.Player.Save(source) | |||
| local pcoords = GetEntityCoords(ped) | |||
| local PlayerData = QBCore.Players[source].PlayerData | |||
| if PlayerData then | |||
| MySQL.insert('INSERT INTO players (citizenid, cid, license, name, money, charinfo, job, gang, position, metadata) VALUES (:citizenid, :cid, :license, :name, :money, :charinfo, :job, :gang, :position, :metadata) ON DUPLICATE KEY UPDATE cid = :cid, name = :name, money = :money, charinfo = :charinfo, job = :job, gang = :gang, position = :position, metadata = :metadata', { | |||
| MySQL.insert('INSERT INTO players (citizenid, cid, license, discord, name, money, charinfo, job, gang, position, metadata) VALUES (:citizenid, :cid, :license, :discord, :name, :money, :charinfo, :job, :gang, :position, :metadata) ON DUPLICATE KEY UPDATE cid = :cid, name = :name, money = :money, charinfo = :charinfo, job = :job, gang = :gang, position = :position, metadata = :metadata', { | |||
There was a problem hiding this comment.
Where is the corresponding Schema update?
server/player.lua
Outdated
| @@ -97,6 +97,7 @@ function QBCore.Player.CheckPlayerData(source, PlayerData) | |||
| if source then | |||
| PlayerData.source = source | |||
| PlayerData.license = PlayerData.license or QBCore.Functions.GetIdentifier(source, 'license') | |||
| PlayerData.discord = PlayerData.discord or QBCore.Functions.GetIdentifier(source, 'discord'):sub(9) | |||
There was a problem hiding this comment.
Forgot to add. What if this is nil? calling :sub on a null may cause an issue. Requires testing.
qbcore.sql
Outdated
| @@ -3,6 +3,7 @@ CREATE TABLE IF NOT EXISTS `players` ( | |||
| `citizenid` varchar(50) NOT NULL, | |||
| `cid` int(11) DEFAULT NULL, | |||
| `license` varchar(255) NOT NULL, | |||
| `discord` varchar(255) NOT NULL, | |||
|
Just updated, I dont really know if |
|
|
|
You will be correct if you are talking about old qbcore, now it uses the native: Lines 24 to 27 in e488cbe |
|
Maybe add something to the config.lua to turn this on and off |
Update QB-Core
|
Well, because the SQL file was change, I feel that it shouldn't be optional |
|
This PR has had 60 days of inactivity & will close within 7 days |
|
What about this? |
|
Could you possibly elaborate on the use case example you mentioned? |
Yes, for example if u want to get have an admin menu to see all players data (no matters they are online or not) it is always easier, mostly for RP servers, to locate players based on discord Id. Also if u want to integrate your sv with a discord bot or maybe a Webpage with discord login this will be helpful. Discord is the main way gaming communities get along right now, and a better integration with this programme providing more critical data storing can become handy. |
|
The idea is fine but needs more thought instead of just saving additional information |
GhzGarage
added
enhancement
|
As I said before, is not only for just saving data, is for future scripts functionality and for easier Web integration |
|
I think it really should be added. This will allow new scripts with new innovations |
Cocodrulo
changed the title
Cocodrulo
changed the title
I agree that this addition is essential. It opens the door for creators to develop innovative scripts and introduces opportunities for further enhancements. It would be a valuable contribution to the project. |
Description
Nowadays most servers using QBCore uses discord whitelist, so the player will have their discord linked to FiveM. To ease integration with webapges I think discord information in main qbcore database table (players) should be kept to easy locate characters linked to a player.
Checklist