-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hkl channel5 reader #465
base: develop
Are you sure you want to change the base?
Hkl channel5 reader #465
Conversation
I realized that ctf reader implementation is already in PR #451. Sorry for duplication... |
Hi Ondrej! Thank you for making this PR. It might be that your work here can improve the already opened PR by @IMBalENce. I'll have a look. Let's keep it open for now. |
Hi @ondrolexa, we've finally merged the CTF reader in #451 into the |
It seems to read my ctf files without problem...
|
Great! But, we should avoid that warning. There seems to be some inconsistency in how we set the symmetry from your file. Do you mind sharing the file? Or even better, if you find the reason why, could you a PR to silence the warning? Also, I see you have listed the CTF error codes in this PR. They would be very nice to have in the CTF reader we just merged. Could you open a new PR and add them to the Notes section in the Lines 70 to 77 in 006e85d
|
Here is a zipped ctf file producing the warning SM3-3.zip. Later I can make a PR to update Notes section of |
Anyway if I remember well, the error codes was adopted from ctfFile3.py file of the xcdskd project... |
Description of the change
Plugin to read crystal map from HKL Channel5 ctf file
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py
.section in
CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.