Fix downloading remote datasets to cache on Windows #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #654 reported by @ericpre.
We use Pooch to manage our
kikuchipy.data
module. Pooch requires file paths with unix-style separators "/" only. However,os.path.join()
, which returns paths with "\"-separators on Windows, was used to create paths passed to Pooch in one place in our data module. Thus the reported error.This PR should fix this issue by using
pathlib.Path
to create paths for Pooch.I tested that it works on a local Windows machine. This issue was not caught by our test suite because it is too computationally expensive to download a file from Zenodo in a test. I'm not sure how to make a computationally inexpensive test that would catch this without calling internal methods in Pooch.
Progress of the PR
Minimal example of the bug fix or new feature
The following works on Windows:
For reviewers
__init__.py
.section in
CHANGELOG.rst
.release.py
,.zenodo.json
and.all-contributorsrc
with the table regenerated.