feat: Upgrade to pywr-v1-schema v0.8.0. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required implementing several new parameters: - InterpolatedParameter - DiscountFactorParameter - DataFrameParameter Conversion from Storage, Deficit and Flow parameters is now returns an error as these should become metrics in pywr-next. Todos are left for HydropowerTarget, RollingMeanFlowNode and ScenarioWrapper parameter. Also the control curve interpolated parameter was renamed due to a naming conflict with InterpolatedParameter.
Batch21
requested changes
Nov 2, 2023
| }) | ||
| .collect::<Result<_, TableError>>()?; | ||
|
|
||
| Ok(LoadedScalarTable::Three(ScalarTableThree { values })) |
There was a problem hiding this comment.
Shouldn't this return a LoadedScalarTable::Two and another function added to create a LoadedScalarTable::Three?
There was a problem hiding this comment.
Hmm yes. Not sure how this is compiling!
| .collect::<Result<_, TableError>>()?; | ||
|
|
||
| Ok(LoadedVecTable::Two(tbl)) | ||
| } |
There was a problem hiding this comment.
Is this missing a load_csv_row3_vec_table_one function?
|
This was a bit broken. I've fixed the |
jetuk
force-pushed
the
pywr-schema-0_8_0
branch
from
77639b8 to
f73def3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required implementing several new parameters:
Conversion from Storage, Deficit and Flow parameters is now returns an error as these should become metrics in pywr-next.
Todos are left for HydropowerTarget, RollingMeanFlowNode and ScenarioWrapper parameter.
Also the control curve interpolated parameter was renamed due to a naming conflict with InterpolatedParameter.