Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pywr master compatibility #10

Open
wants to merge 5 commits into
base: battery-balance
Choose a base branch
from
Open

Pywr master compatibility #10

wants to merge 5 commits into from

Conversation

pmslavin
Copy link

@pmslavin pmslavin commented Feb 9, 2022

Changes made in pmslavin/pywr-dcopf.pywr_master_compat introduce compatibility with current Pywr master.

  • Updates node types to support new Pywr loading procedure.
  • Adds test for behaviour of initial_volume_pc arg of Battery node.
  • Miscellaneous layout and node ctor validation changes.

@jetuk
Copy link
Member

jetuk commented Feb 9, 2022

Thanks @pmslavin. I'll find time to review this. Reminds me this repo needs to have the CI setup. That might be a bit easier following the new pywr approach with Github Actions.

@jetuk jetuk self-requested a review February 27, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetuk jetuk Awaiting requested review from jetuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmslavin @jetuk