Delete error solved #180
Open
Delete error solved #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 90.57% 90.55% -0.02%
==========================================
Files 24 24
Lines 5239 5240 +1
==========================================
Hits 4745 4745
- Misses 494 495 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pnuu
requested changes
Sep 8, 2023
There was a problem hiding this comment.
This will need a unit test that checks the three options work:
- user doesn't define
deletein the config -> the default is used - user defines
delete = Trueand the file is deleted - user defines
delete = Falseand the file is not deleted
The current implementation will fail on the True case.
| @@ -945,7 +945,7 @@ def unpack(pathname, | |||
| except Exception: | |||
| LOGGER.exception("Could not decompress %s", pathname) | |||
| else: | |||
| if delete.lower() in ["1", "yes", "true", "on"]: | |||
| if delete in ["1", "yes", "true", "on"]: | |||
There was a problem hiding this comment.
This won't work if delete is set to any value that evaluates as boolean True.
|
@pnuu I traced all the options (1,yes..) back to True. If I use test_server.py on test folder I have no error message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On server.py the delete option accepts only boolean
False, without quotes. An error occurred when you're working for the decompression of files on the fly.