Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx documentation #54

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Oct 3, 2019

Update Sphinx doc pages, and enhance documentation

Signed-off-by: Adam Dybbroe [email protected]

@adybbroe adybbroe self-assigned this Oct 3, 2019
@adybbroe adybbroe requested review from mraspaud and pnuu October 3, 2019 01:57
@adybbroe adybbroe added the enhancement New feature or request label Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          10       10           
  Lines        1277     1277           
=======================================
  Hits         1146     1146           
  Misses        131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f44be4...5c5fa64. Read the comment docs.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what these changes actually do, but found one typo.

@@ -19,27 +15,87 @@
# import os
# import sys
# sys.path.insert(0, os.path.abspath('.'))
import pyspectral.version as current_version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste typo? Maybe this should be from trollflow2 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, baad, thx @pnuu !
Will fix...

@mraspaud
Copy link
Member

@adybbroe where are we on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants