Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures #201

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Fix test failures #201

merged 10 commits into from
Feb 29, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 28, 2024

This PR fixes couple of test failures.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes flake8 trollflow2
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@pnuu pnuu added the bug Something isn't working label Feb 28, 2024
@pnuu pnuu self-assigned this Feb 28, 2024
@pnuu pnuu requested a review from mraspaud as a code owner February 28, 2024 11:27
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (0713a86) to head (a4ac1f5).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   95.76%   95.80%   +0.03%     
==========================================
  Files          13       13              
  Lines        2972     3000      +28     
==========================================
+ Hits         2846     2874      +28     
  Misses        126      126
Flag Coverage Δ
unittests 95.80% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnuu pnuu mentioned this pull request Feb 28, 2024
Merged
6 tasks
@mraspaud
Merge pull request pytroll#199 from mraspaud/fix-logging
aaf85a9 
Fix logging to handler config without loggers
mraspaud
mraspaud requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the time test needs to be fixed (see inline comment).

trollflow2/tests/test_trollflow2.py Outdated Show resolved Hide resolved
mraspaud
mraspaud previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu dismissed mraspaud’s stale review February 29, 2024 08:33

The merge-base changed after approval.

mraspaud
mraspaud approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit dc4b933 into pytroll:main Feb 29, 2024
9 checks passed
@pnuu pnuu deleted the debug-ci-failures branch February 29, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

Assignees

@pnuu pnuu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnuu @mraspaud @lahtinep