Clip negative FCI radiances #3013
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (8.07 -> 8.07)
-
Declining Code Health: 2 findings(s) 🚩
-
Affected Hotspots: 2 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Excess Number of Function Arguments fci_l1c_nc.py: FCIL1cNCFileHandler.init 🔥
- Excess Number of Function Arguments image_comparison.py: step_when_generate_image
Annotations
Check warning on line 92 in satpy/tests/behave/features/steps/image_comparison.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
step_when_generate_image has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 1 in satpy/tests/reader_tests/test_fci_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 632 to 648, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 237 in satpy/readers/fci_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
FCIL1cNCFileHandler.__init__ has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.