Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t865 dataset to olci l2 list #3007

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 4, 2024

This PR adds the t865 dataset to olci l2 list.

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Dec 4, 2024
@mraspaud mraspaud self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (80c93cb) to head (0589f61).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3007      +/-   ##
==========================================
+ Coverage   96.08%   96.10%   +0.01%     
==========================================
  Files         377      377              
  Lines       55155    55162       +7     
==========================================
+ Hits        52997    53012      +15     
+ Misses       2158     2150       -8     
Flag Coverage Δ
behaviourtests 3.94% <ø> (-0.01%) ⬇️
unittests 96.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12163468541

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 96.208%

Totals Coverage Status
Change from base Build 12131887891: 0.01%
Covered Lines: 53256
Relevant Lines: 55355

💛 - Coveralls

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the units are udunits compatible then LGTM

@mraspaud
Copy link
Member Author

mraspaud commented Dec 4, 2024

Assuming the units are udunits compatible then LGTM

They are!

@mraspaud mraspaud merged commit 9b817a4 into pytroll:main Dec 4, 2024
18 checks passed
@mraspaud mraspaud deleted the feature-olci-l2-w_aer branch December 4, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants