Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: li missing platform name #2993

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix_li_reader_platform_attribute

c1c7357
Select commit
Loading
Failed to load commit list.
Open

fix: li missing platform name #2993

Merge branch 'main' into fix_li_reader_platform_attribute
c1c7357
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 5, 2024 in 1m 4s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.30 (9.05 -> 8.76)

  • Declining Code Health: 2 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Lines of Code in a Single File test_li_l2_nc.py 🔥
  • Code Duplication test_li_l2_nc.py 🔥

Annotations

Check warning on line 1 in satpy/tests/reader_tests/test_li_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Lines of Code in a Single File

This module has 676 lines of code, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in satpy/tests/reader_tests/test_li_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Low Cohesion

The number of different responsibilities increases from 28 to 29, threshold = 4. Cohesion is calculated using the LCOM4 metric. Low cohesion means that the module/class has multiple unrelated responsibilities, doing too many things and breaking the Single Responsibility Principle.

Check warning on line 208 in satpy/tests/reader_tests/test_li_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 7 functions with similar structure: TestLIL2.test_dataset_not_in_provided_dataset,TestLIL2.test_generate_coords_inverse_proj,TestLIL2.test_generate_coords_on_accumulated_prods,TestLIL2.test_generate_coords_on_lon_lat and 3 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.