Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seviri_l2_grib end_time property bug. #2943

Merged
merged 2 commits into from
Oct 22, 2024

Merge branch 'main' into bugfix_seviri_l2_grib

9c1075c
Select commit
Loading
Failed to load commit list.
Merged

Fix seviri_l2_grib end_time property bug. #2943

Merge branch 'main' into bugfix_seviri_l2_grib
9c1075c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 21, 2024 in 31s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.61 -> 9.61)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method test_eum_l2_grib.py: test_seviri_data_reading

Annotations

Check warning on line 145 in satpy/tests/reader_tests/test_eum_l2_grib.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

test_seviri_data_reading increases from 73 to 74 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis