Changes to Eumetsat L2 BUFR reader #2603
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.11 (9.85 -> 9.74)
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Bumpy Road Ahead eum_l2_bufr.py: EumetsatL2BufrFileHandler.get_attributes
- Bumpy Road Ahead eum_l2_bufr.py: EumetsatL2BufrFileHandler.get_dataset
✅ Improving Code Health:
- Excess Number of Function Arguments eum_l2_bufr.py: SeviriL2BufrFileHandler.init
Annotations
Check warning on line 206 in satpy/readers/eum_l2_bufr.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
EumetsatL2BufrFileHandler.get_attributes has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 262 in satpy/readers/eum_l2_bufr.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
EumetsatL2BufrFileHandler.get_dataset has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 130 in satpy/readers/eum_l2_bufr.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
SeviriL2BufrFileHandler.__init__ is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 123 in satpy/readers/eum_l2_bufr.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Excess Number of Function Arguments
EumetsatL2BufrFileHandler.__init__ has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.