Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ABI "night_microphysics_abi" composite to "night_microphysics" #2574

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 13, 2023

A simple change with a big difference. The default night_microphysics recipe results in the ABI C14 channel being used, but NASA/NOAA/CIRA recommend using C13. This changes the final result a decent amount. The enhancement crude stretch was already changed a long time ago to match the CIRA Quick Guide:

https://rammb.cira.colostate.edu/training/visit/quick_guides/QuickGuide_GOESR_NtMicroRGB_Final_20191206.pdf

But I didn't realize that asking for night_microphysics would give you the C14 version of the composite. This C13 version was only available via the name night_microphysics_abi. This PR changes the name of that composite so it is the main and only night_microphysics loaded for ABI data.

CC @kathys @graemely @ScottLindstrom for any thoughts or disagreement with this being the new default in our Geo2Grid project.

Looking at the differences it is kind of like you add a shadow effect to the red regions of the image.

Old Night Micro

image

New Night Micro

image

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese added enhancement code enhancements, features, improvements component:compositors backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Sep 13, 2023
@djhoese djhoese self-assigned this Sep 13, 2023
@djhoese djhoese changed the title Rename "night_microphsyics_abi" composite to "night_microphysics" Rename ABI "night_microphsyics_abi" composite to "night_microphysics" Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2574 (82c57c7) into main (68af9cd) will decrease coverage by 0.01%.
Report is 17 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   94.91%   94.91%   -0.01%     
==========================================
  Files         351      351              
  Lines       51217    51215       -2     
==========================================
- Hits        48613    48611       -2     
  Misses       2604     2604              
Flag Coverage Δ
behaviourtests 4.29% <ø> (+<0.01%) ⬆️
unittests 95.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6175422820

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.466%

Totals Coverage Status
Change from base Build 6146020463: 0.0%
Covered Lines: 48726
Relevant Lines: 51040

💛 - Coveralls

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The "original" recipe from EUMETSAT uses the SEVIRI bands at 3.9, 10.8 and 12.0 um. The ABI C14 channel (barely) meets the 10.8 specification ([10.80, 11.20, 11.60]) so I guess that's why it's been used. I think I'll also adapt my own configs to use C13 ([10.10, 10.35, 10.60]) instead of the current C14.

@djhoese djhoese changed the title Rename ABI "night_microphsyics_abi" composite to "night_microphysics" Rename ABI "night_microphysics_abi" composite to "night_microphysics" Sep 14, 2023
@djhoese
Copy link
Member Author

djhoese commented Sep 27, 2023

Should I maybe make the "eumetsat" version of the composite available under abi.yaml as night_microphysics_eum? @pnuu @mraspaud ?

@simonrp84
Copy link
Member

Yeah, this looks good to me. A EUM version might also be useful to add.

@djhoese
Copy link
Member Author

djhoese commented Oct 4, 2023

I did add an _eum alias for the old recipe. I think this is good to go now. Merging...

@djhoese djhoese merged commit 89ebe00 into pytroll:main Oct 4, 2023
15 of 17 checks passed
@djhoese djhoese deleted the feat-abi-rename-nightmicro branch October 4, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants