-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ABI "night_microphysics_abi" composite to "night_microphysics" #2574
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2574 +/- ##
==========================================
- Coverage 94.91% 94.91% -0.01%
==========================================
Files 351 351
Lines 51217 51215 -2
==========================================
- Hits 48613 48611 -2
Misses 2604 2604
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pull Request Test Coverage Report for Build 6175422820
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The "original" recipe from EUMETSAT uses the SEVIRI bands at 3.9, 10.8 and 12.0 um. The ABI C14 channel (barely) meets the 10.8 specification ([10.80, 11.20, 11.60]
) so I guess that's why it's been used. I think I'll also adapt my own configs to use C13 ([10.10, 10.35, 10.60]
) instead of the current C14.
Yeah, this looks good to me. A EUM version might also be useful to add. |
I did add an |
A simple change with a big difference. The default
night_microphysics
recipe results in the ABI C14 channel being used, but NASA/NOAA/CIRA recommend using C13. This changes the final result a decent amount. The enhancement crude stretch was already changed a long time ago to match the CIRA Quick Guide:https://rammb.cira.colostate.edu/training/visit/quick_guides/QuickGuide_GOESR_NtMicroRGB_Final_20191206.pdf
But I didn't realize that asking for
night_microphysics
would give you the C14 version of the composite. This C13 version was only available via the namenight_microphysics_abi
. This PR changes the name of that composite so it is the main and only night_microphysics loaded for ABI data.CC @kathys @graemely @ScottLindstrom for any thoughts or disagreement with this being the new default in our Geo2Grid project.
Looking at the differences it is kind of like you add a shadow effect to the red regions of the image.
Old Night Micro
New Night Micro
AUTHORS.md
if not there already