Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New reader for Himawari L2 NOAA enterprise cloud products. #2558

Merged
merged 19 commits into from
Oct 11, 2023

Minor updates to AHI L2 reader and the tests.

8cbe04a
Select commit
Loading
Failed to load commit list.
Merged

New reader for Himawari L2 NOAA enterprise cloud products. #2558

Minor updates to AHI L2 reader and the tests.
8cbe04a
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 10, 2023 in 29s

CodeScene PR Check

✅ Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

  • Code Duplication test_ahi_l2_nc.py

Annotations

Check warning on line 53 in satpy/tests/reader_tests/test_ahi_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication 

The module contains 2 functions with similar structure: himl2_filename,himl2_filename_bad. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis