Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nwp runner fix #61

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Nwp runner fix #61

merged 7 commits into from
Apr 25, 2024

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented Apr 18, 2024 •
edited
Loading

Some fixes to the nwp runner

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest nwcsafpps_runner
  • Passes flake8 nwcsafpps_runner
  • Fully documented

mraspaud
mraspaud reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would it be possible to add tests so that these bugs can be prevented from returning?

@adybbroe adybbroe self-requested a review April 19, 2024 10:58
adybbroe
adybbroe approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added the bug label Apr 25, 2024
@mraspaud mraspaud merged commit 311997d into pytroll:main Apr 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud left review comments

@adybbroe adybbroe adybbroe approved these changes

Assignees

@ninahakansson ninahakansson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninahakansson @mraspaud @adybbroe