Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metimage #59

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Metimage #59

merged 4 commits into from
Jan 19, 2024

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented Jan 16, 2024

Added metimage as service

  • Tests added

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ae0a967) 70.62% compared to head (8eb6b4c) 70.55%.

Files Patch % Lines
nwcsafpps_runner/utils.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   70.62%   70.55%   -0.07%     
==========================================
  Files          15       15              
  Lines        2192     2201       +9     
  Branches      293      296       +3     
==========================================
+ Hits         1548     1553       +5     
- Misses        602      606       +4     
  Partials       42       42              
Flag Coverage Δ
unittests 70.55% <69.23%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this!

@adybbroe adybbroe merged commit fc4314d into pytroll:main Jan 19, 2024
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants