Moved code for checking host to function

Added some tests

nwcsafpps_runner/tests/test_utils.py

@@ -27,11 +27,16 @@
 from nwcsafpps_runner.utils import (create_xml_timestat_from_lvl1c,
                                     get_lvl1c_file_from_msg,
                                     find_product_statistics_from_lvl1c,
+                                    ready2run,
                                     publish_pps_files)
 from nwcsafpps_runner.utils import FindTimeControlFileError
 
 TEST_MSG = """pytroll://segment/EPSSGA/1B/ file [email protected] 2023-02-17T08:18:15.748831 v1.01 application/json {"start_time": "2023-02-17T08:03:25", "end_time": "2023-02-17T08:15:25", "orbit_number": 99999, "platform_name": "Metop-SG-A1", "sensor": "metimage", "format": "X", "type": "NETCDF", "data_processing_level": "1b", "variant": "DR", "orig_orbit_number": 23218, "uri": "/san1/polar_in/direct_readout/metimage/W_XX-EUMETSAT-Darmstadt,SAT,SGA1-VII-1B-RAD_C_EUMT_20210314224906_G_D_20070912101704_20070912101804_T_B____.nc", "uid": "W_XX-EUMETSAT-Darmstadt,SAT,SGA1-VII-1B-RAD_C_EUMT_20210314224906_G_D_20070912101704_20070912101804_T_B____.nc"}"""  # noqa: E501
 
+TEST_MSG_UID = """pytroll://segment/EPSSGA/1B/ file [email protected] 2023-02-17T08:18:15.748831 v1.01 application/json {"start_time": "2023-02-17T08:03:25", "end_time": "2023-02-17T08:15:25", "orbit_number": 99999, "platform_name": "Metop-SG-A1", "sensor": "metimage", "format": "X", "type": "NETCDF", "data_processing_level": "1b", "variant": "DR", "orig_orbit_number": 23218, "uid": "W_XX-EUMETSAT-Darmstadt,SAT,SGA1-VII-1B-RAD_C_EUMT_20210314224906_G_D_20070912101704_20070912101804_T_B____.nc", "uid": "W_XX-EUMETSAT-Darmstadt,SAT,SGA1-VII-1B-RAD_C_EUMT_20210314224906_G_D_20070912101704_20070912101804_T_B____.nc", "destination": "/san1/polar_in/direct_readout/metimage"}"""  # noqa: E501
+
+TEST_MSG_BAD = """pytroll://segment/EPSSGA/1B/ dataset [email protected] 2023-02-17T08:18:15.748831 v1.01 application/json {"start_time": "2023-02-17T08:03:25", "end_time": "2023-02-17T08:15:25", "orbit_number": 99999, "platform_name": "Metop-SG-A1", "sensor": "metimage", "format": "X", "type": "NETCDF", "data_processing_level": "1b", "variant": "DR", "orig_orbit_number": 23218, "uid": "W_XX-EUMETSAT-Darmstadt,SAT,SGA1-VII-1B-RAD_C_EUMT_20210314224906_G_D_20070912101704_20070912101804_T_B____.nc", "uid": "W_XX-EUMETSAT-Darmstadt,SAT,SGA1-VII-1B-RAD_C_EUMT_20210314224906_G_D_20070912101704_20070912101804_T_B____.nc", "destination": "/san1/polar_in/direct_readout/metimage"}"""  # noqa: E501
+
 
 @pytest.fixture
 def fake_file_dir(tmp_path):
@@ -120,6 +125,21 @@ def test_xml_for_products_no_file4pps(self, fake_file_dir):
         assert res == []
 
 
+class TestReady2Run(unittest.TestCase):
+    """Test ready2run function."""
+
+    def test_ready2run(self):
+        from posttroll.message import Message
+        input_msg = Message.decode(rawstr=TEST_MSG)
+        mymodule = MagicMock()
+        import sys
+        sys.modules["check_host_ok"] = mymodule
+        ok2run = ready2run(input_msg, {"file4pps": "dummy"})
+        self.assertTrue(ok2run)
+        ok2run = ready2run(input_msg, {"file4pps": None})
+        self.assertFalse(ok2run)
+
+
 class TestPublishPPSFiles(unittest.TestCase):
     """Test publish pps files."""
 
@@ -155,6 +175,24 @@ def test_get_lvl1c_file_from_msg(self):
             "20210314224906_G_D_20070912101704_20070912101804_T_B____.nc")
         self.assertEqual(file1, file_exp)
 
+    def test_get_lvl1c_file_from_msg_uid(self):
+        """Test get_lvl1c_file_from_message."""
+        from posttroll.message import Message
+        input_msg = Message.decode(rawstr=TEST_MSG_UID)
+        file1 = get_lvl1c_file_from_msg(input_msg)
+        file_exp = (
+            "/san1/polar_in/direct_readout/metimage/" +
+            "W_XX-EUMETSAT-Darmstadt,SAT,SGA1-VII-1B-RAD_C_EUMT_" +
+            "20210314224906_G_D_20070912101704_20070912101804_T_B____.nc")
+        self.assertEqual(file1, file_exp)
+
+    def test_get_lvl1c_file_from_msg_bad(self):
+        """Test get_lvl1c_file_from_message."""
+        from posttroll.message import Message
+        input_msg = Message.decode(rawstr=TEST_MSG_BAD)
+        file1 = get_lvl1c_file_from_msg(input_msg)
+        self.assertEqual(file1, None)
+
 
 if __name__ == "__main__":
     pass

nwcsafpps_runner/utils.py

@@ -175,26 +175,20 @@ def get_lvl1c_file_from_msg(msg):
     else:
         LOG.debug(
             "Ignoring this type of message data: type = " + str(msg.type))
-        return []
+        return None
 
     try:
         level1c_files = check_uri(uris)
     except IOError:
         LOG.info('One or more files not present on this host!')
-        return []
+        return None
 
     LOG.debug("files4pps: %s", str(level1c_files))
-    if len(level1c_files) < 1:
-        LOG.info("No level1c files!")
-        return []
-
     return level1c_files[0]
 
 
-def ready2run(msg, scene, **kwargs):
-    """Check whether pps is ready to run or not."""
-
-    LOG.info("Got message: " + str(msg))
+def check_host_ok(msg):
+    """Check that host is ok."""
     try:
         url_ip = socket.gethostbyname(msg.host)
         if url_ip not in get_local_ips():
@@ -203,6 +197,18 @@ def ready2run(msg, scene, **kwargs):
     except (AttributeError, socket.gaierror) as err:
         LOG.error("Failed checking host! Hostname = %s", socket.gethostname())
         LOG.exception(err)
+    return True
+
+
+def ready2run(msg, scene, **kwargs):
+    """Check whether pps is ready to run or not."""
+
+    LOG.info("Got message: " + str(msg))
+    if not check_host_ok(msg):
+        return False
+
+    if scene['file4pps'] is None:
+        return False
 
     if msg.data['platform_name'] in SUPPORTED_PPS_SATELLITES:
         LOG.info(