-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SIGTERM handling to geographic gatherer #157
Add SIGTERM handling to geographic gatherer #157
Conversation
Locally I have an issue with the tests never exiting. The tests pass, but then hang until CTRL+C:
The actual functionality seems to work fine when running the main script. At least when there are no collecting going on, which I don't have an easy way to test. |
Running the actual script in terminal and killing the process:
|
In 962e875 I mock the trigger creation. I think I need to create a more involved mock or fake trigger creation with collectors to simulate the structure so that the checks in |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 91.82% 91.78% -0.05%
==========================================
Files 28 28
Lines 3953 4005 +52
==========================================
+ Hits 3630 3676 +46
- Misses 323 329 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11817159508Details
💛 - Coveralls |
With e866900 I think the new feature is "fully" tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds SIGTERM handling to geographic gatherer.
After receiving the signal, the gatherer will wait until all active collections have been finished and then exit the program.