Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sensor list in topic #154

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ninahakansson
Copy link

In case of list of sensor, use MULTIPLE_SENSORS in topic. We do not want a tuple or lsit in the publishing topic.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (afb6cae) to head (49d5fe0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   91.78%   91.80%   +0.02%     
==========================================
  Files          28       28              
  Lines        4005     4017      +12     
==========================================
+ Hits         3676     3688      +12     
  Misses        329      329              
Flag Coverage Δ
unittests 91.80% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 12412964800

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 90.799%

Totals Coverage Status
Change from base Build 11931253671: 0.02%
Covered Lines: 4125
Relevant Lines: 4543

💛 - Coveralls

@adybbroe adybbroe self-requested a review May 3, 2024 08:17
@adybbroe adybbroe self-assigned this May 3, 2024
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small comment it looks good, thanks!

@adybbroe adybbroe requested a review from mraspaud May 3, 2024 08:29
@ninahakansson
Copy link
Author

ninahakansson commented May 3, 2024

Unfortunately isinstance("atms", collections.abc.Sequence) is also True ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants