-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract calibration modules from the reader #127
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 74.22% 76.11% +1.89%
==========================================
Files 33 32 -1
Lines 3115 3195 +80
==========================================
+ Hits 2312 2432 +120
+ Misses 803 763 -40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I like the entry-point approach. Should have started reading with the tests, they are pretty clear 👍
@sfinkens if you could review again, that would be great :) I have address all you comment I think, and did some more refactoring. I need to do more, but I will do that in another PR, along with extracting the navigation module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks for all the refactoring effort!
This PR extracts calibration modules from the reader.
As we are preparing to add new calibration and navigation algorithms for pygac, it needs to be upgraded to be made more modular.