Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python-3.8 support #112

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Drop Python-3.8 support #112

merged 2 commits into from
Nov 17, 2023

Conversation

sfinkens
Copy link
Member

Drop Python-3.8 support since Satpy requires Python >= 3.9

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bbcb66) 64.06% compared to head (2dd4d7c) 64.06%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   64.06%   64.06%           
=======================================
  Files           8        8           
  Lines         693      693           
=======================================
  Hits          444      444           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfinkens sfinkens requested a review from mraspaud November 16, 2023 08:22
@djhoese
Copy link
Member

djhoese commented Nov 16, 2023

FYI I think we're planning on dropping 3.9 in Satpy soon as numpy and other scientific python libraries are also dropping it. I guess that can be a future PR for pygac.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could test with 3.12, but otherwise this looks good to me. If you don't bump the experimental end-to-end with 3.12 then I think it should at least be 3.11.

@sfinkens
Copy link
Member Author

Thanks for taking the time!

@sfinkens sfinkens merged commit 524d2b5 into pytroll:main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants