ci: Remove mentions of conda-forge #4082
Conversation
We run into a lot of build / runtime issues when relying on things from conda-forge. Now that Python 3.9 is more thoroughly supported on the default anaconda channel lets remove the hooks for conda-forge now. Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
remove_conda_forge
branch
from
8a6e5e4 to
c333ae0
Compare
There was a problem hiding this comment.
Thanks @seemethere , I'll stamp to unblock but I wonder if the CI failure is related?
It is related since cudatoolkit=11.1 is only available for linux on the nvidia channel, cc @ptrblck can we get the nvidia team to upload cudatoolkit=11.1 for windows on the nvidia conda channel? |
| conda create ${CONDA_CHANNEL_FLAGS} -yn "env$PYTHON_VERSION" python="$PYTHON_VERSION" | ||
| conda activate "env$PYTHON_VERSION" | ||
| # Install libpng from Anaconda (defaults) | ||
| conda install ${CONDA_CHANNEL_FLAGS} -c conda-forge libpng "jpeg<=9b" -y | ||
| conda install ${CONDA_CHANNEL_FLAGS} libpng "jpeg<=9b" -y |
There was a problem hiding this comment.
I think you meant to remove CONDA_CHANNEL_FLAGS here?
There was a problem hiding this comment.
I think it might still be valuable to have the mechanism to insert channels into these easily.
For example I think we might go through this same exercise when attempting to add Python 3.10 support later on this year.
Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
remove_conda_forge
branch
from
555a2e3 to
55d3cbe
Compare
Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
remove_conda_forge
branch
from
5f4242f to
fb796cb
Compare
|
Alright all of the relevant builds are passing here will merge once I get signal again |
|
Hey @seemethere! You merged this PR, but no labels were added. |
What? |
|
@seemethere we have a bot to ping us if we forget to add labels to merged PRs (to categorize between improvement / bugfix / etc). The labels are used to facilitate release notes creation. Don't worry, we will add the labels |
Reviewed By: NicolasHug Differential Revision: D29369897 fbshipit-source-id: a8c883cb0077952a1e22a00e34fab88594c1af0d
(cherry picked from commit d391a0e) Signed-off-by: Eli Uriegas <[email protected]>
We run into a lot of build / runtime issues when relying on things from
conda-forge. Now that Python 3.9 is more thoroughly supported on the
default anaconda channel lets remove the hooks for conda-forge now.
This PR also removes the
avdependency from the condameta.yamlsince it's currently only available withinconda-forge.It isn't critical to run the import smoke tests that we specify for conda and the test coverage should already be covered by the unit tests which do install
avbut choose to install it frompypiinstead. (which cannot be done withconda-build, see conda/conda-build#548)I think not having
avwithin the conda recipe should be fine considering the trade-off is having to useconda-forgefor all of our dependencies.Resolves #4076
Signed-off-by: Eli Uriegas [email protected]