Fix ModuleNotFoundError: No module named 'skimage' when importing torcheval #205
Conversation
|
Hi @fleonce! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@bobakfb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for this fix! Testing! |
torcheval/metrics/image/ssim.py
Outdated
| from typing import Iterable, Optional, TypeVar | ||
|
|
||
| import torch | ||
|
|
||
| from skimage.metrics import structural_similarity | ||
| if find_spec("torchvision") is not None: |
There was a problem hiding this comment.
Shouldn't this be find_spec("skimage")?
There was a problem hiding this comment.
Absolutely, will fix
torcheval/metrics/image/ssim.py
Outdated
| def _validate_torchvision_available() -> None: | ||
| if not _SKIMAGE_AVAILABLE: | ||
| raise RuntimeError( | ||
| "You must have skimage installed to use SSIM, please install torcheval[image]" |
There was a problem hiding this comment.
extra tab here the linter is angry about
|
Hi @fleonce I've requested two minor changes for this to land, if you can push an update by tomorrow I will take this, otherwise I will just push with these changes on my end. |
|
@bobakfb changes should be up, thanks for reviewing |
|
sorry looks like another linting issue (need newline at the end of the requirements file), can you make sure you run |
|
yeah, sure, sorry about that. pre commit runs fine on my machine now. image-requirements.txt needed a new line at the end of the file |
|
@bobakfb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Still breaking tests, but this is a prior failure that is fixed in #207 |
|
@bobakfb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Prevent ModuleNotFoundError when skimage is not installed
Test plan:
None
Fixes #204