Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfeasibilityError exception #2652

Closed
wants to merge 1 commit into from

Conversation

Waschenbacher
Copy link
Contributor

Motivation

Add customised error for infeasible problem. Details see #2631

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

The customised error is tested in a similar way as the other customised errors.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/pytorch/botorch, and link to your PR here.)

Copy link

vercel bot commented Dec 15, 2024

Deployment failed with the following error:

Preview deployments are disabled for this project.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 15, 2024
@Balandat
Copy link
Contributor

Thanks - should we derive InfeasibilityError from ValueError? So that this is backward-compatible if folks were catching the ValueError before?

@Waschenbacher
Copy link
Contributor Author

Thanks - should we derive InfeasibilityError from ValueError? So that this is backward-compatible if folks were catching the ValueError before?

@Balandat Thanks! Makes totally sense! I have made the requested change. Just a side note: the test failed on my local machine even before I made any changes, so I am unable to pass the test.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (299438b) to head (4c2f418).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2652    +/-   ##
========================================
  Coverage   99.98%   99.98%            
========================================
  Files         198      200     +2     
  Lines       17911    18155   +244     
========================================
+ Hits        17909    18153   +244     
  Misses          2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in 7715ff4.

@Balandat
Copy link
Contributor

Thanks for the contribution, @Waschenbacher!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants