Skip to content

Commit

Permalink
Fix the failed ShipIt task
Browse files Browse the repository at this point in the history
Summary:
ShipIt does not allow multiple internal files mapping to the same GitHub file, we are violating this rule because:

1. In the ShipIt config, we are mapping `pytorch/benchmark` to github https://github.com/pytorch/benchmark: https://www.internalfb.com/code/configerator/source/opensource/shipit_config/pytorch/benchmark.cconf
Therefore, it is mapping `huggingface.yaml` to userbenchmark/dynamo/dynamobench/huggingface.yaml

2. The ShipIt config also explicitly maps "fbcode/caffe2/benchmarks/dynamo/huggingface.yaml" to "userbenchmark/dynamo/dynamobench/huggingface.yaml"

We should use "fbcode/caffe2/benchmarks/dynamo/huggingface.yaml" as the single ground of truth. Therefore, we are removing the pytorch/benchmark/userbenchmark/dynamo/dynamobench/huggingface.yaml

Reviewed By: kit1980

Differential Revision: D65695792

fbshipit-source-id: b0ddc342aba3166175de962b3d05eb3c77d8b090
  • Loading branch information
xuzhao9 authored and facebook-github-bot committed Nov 9, 2024
1 parent ff80dde commit 0ec8bc2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ numpy
opencv-python
submitit
pynvml
pandas
scipy
2 changes: 0 additions & 2 deletions userbenchmark/dynamo/dynamobench/requirements.txt

This file was deleted.

0 comments on commit 0ec8bc2

Please sign in to comment.